Skip to content

Conversation

@dhardy
Copy link
Member

@dhardy dhardy commented Oct 31, 2025

@newpavlov @josephlr this is a cut-down version of rust-random/getrandom#740 with only the GitHub release automation.

This assumes tags of the form "0.9.2" (no leading 'v'), which is what we've been using in rand. I have such tags from past releases ready to push after this is merged.

@dhardy dhardy force-pushed the push-rulwmxttyvww branch from e239952 to 6b67bd5 Compare October 31, 2025 08:11
@newpavlov
Copy link
Member

newpavlov commented Oct 31, 2025

This assumes tags of the form "0.9.2" (no leading 'v'), which is what we've been using in rand.

Maybe it's worth to switch to the v0.9.2 tagging scheme? I think it's much more popular across Rust crates.

@dhardy
Copy link
Member Author

dhardy commented Oct 31, 2025

I only really see disadvantages of the v* notation (the exception being the more complex pattern matching used in this PR).

@dhardy dhardy merged commit 2c1b24b into master Oct 31, 2025
13 checks passed
@dhardy dhardy deleted the push-rulwmxttyvww branch October 31, 2025 14:09
@dhardy
Copy link
Member Author

dhardy commented Oct 31, 2025

The job isn't running on newly pushed tags which should match the given pattern. Do you know how to debug this?

Spec: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet

@newpavlov
Copy link
Member

newpavlov commented Oct 31, 2025

It looks like you've missed one indentation level after line 25, which causes the following error:

(Line: 25, Col: 7): There's not enough info to determine what you meant. Add one of these properties: run, shell, uses, with, working-directory, (Line: 28, Col: 5): Unexpected value 'run'

@newpavlov
Copy link
Member

Hm, no. I was wrong. The config in master looks correct.

@newpavlov
Copy link
Member

newpavlov commented Oct 31, 2025

The regexp may be incorrect. I get the following error for * on regex101.com:

* The preceding token is not quantifiable

@newpavlov
Copy link
Member

newpavlov commented Oct 31, 2025

Also note that your forgot the cargo publish part. Was it intentional?

@dhardy
Copy link
Member Author

dhardy commented Oct 31, 2025

This is some form of glob pattern not a regexp. That's part of the problem.

No, I didn't publish; I just pushed a couple of old tags.

@newpavlov
Copy link
Member

newpavlov commented Oct 31, 2025

Try to remove * and see whether it would get triggered by pushing tag for 0.2.0? It obviously would not work for pre-releases, but we would at least check whether * causes issues or not.

@dhardy
Copy link
Member Author

dhardy commented Oct 31, 2025

No dice. I'll try with a 'v' prefix.

@newpavlov
Copy link
Member

I pushed v0.0.0 tag to the latest master commit and it triggered the workflow. So it seems it may not work on older commits for some reason.

@dhardy
Copy link
Member Author

dhardy commented Oct 31, 2025

Oh... I wondered where that came from.

@newpavlov
Copy link
Member

I think I understand why the workflow does not get triggered. GH looks for configs in the commit itself, so if we tag an older commit, GH thinks that there is no such workflow.

@dhardy
Copy link
Member Author

dhardy commented Oct 31, 2025

Confirmed: tagging 0.10.0-rc-1 works since this matches what was in release.yml at the time.

@newpavlov
Copy link
Member

newpavlov commented Oct 31, 2025

BTW release names (i.e "release_0.10.0-rc-1") look a bit ugly in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants